Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Digitals Boxing Ring collision hands demo #495

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

BastiaanOlij
Copy link
Member

First in a couple of PRs that will add Digitals boxing ring demo (#478) into XR Tools while solving a number of rebase issues and adjust the demo to work with the logic we're polishing up.

I'm not finished with this yet as time is short but some early feedback would be appreciated.

Things that will be fixed/dealt with in follow up PRs:

  • Digitals improvement that copies collision shapes when you grab an object is still missing from this (I'm also planning on adding collisions for fingers)
  • Digitals improvement for reacting to the weight of the item being picked up is still missing from this
  • When dropping an object it will often collide with the collision hands and go flying off, Malcolm is working on a fix for this
  • The climbing wall will return, we're working on a different solution for the hand grabbing.
  • Two handed pickup will return, this was still experimental even in Digitals PR and we want to separate it out so it doesn't become a blocking issue.

@BastiaanOlij BastiaanOlij added the enhancement New feature or request label Aug 5, 2023
@BastiaanOlij BastiaanOlij added this to the 4.2.0 milestone Aug 5, 2023
@BastiaanOlij BastiaanOlij self-assigned this Aug 5, 2023
@BastiaanOlij BastiaanOlij modified the milestones: 4.2.0, 4.3.0 Aug 22, 2023
@BastiaanOlij BastiaanOlij modified the milestones: 4.3.0, 4.4.0 Nov 28, 2023
@DigitalN8m4r3
Copy link
Contributor

bump
from what i understand, this apparently will not be completed for 4.3 and we might want to move this to xr tools v2.

from my pov, i tried recreating the pickable collision logic with the New collision hand and it falls and overcomplicates, we would need to account for twohanded and for evry other extra handposition, this would mean to either move the collision copy evry time or to Delete and recreate it, this Producess unwanted physics reactions

Regarding weight, i was unable to add drag to the forcebody3d node, probably just my lack of skill here.

Amyways, this pr is soon havin its 1st birthday, so cake or no is the question

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants