Implement OpenID Connect session tracking iframes #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The iframes will call the /identity/authentication/finishlogout page when login session change is detected.
|
Thanks Mark. We'll have to take some time to process this. But it looks like some nice work. |
|
@yurem or @shekhar16 can you review this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds openid connect session tracking iframes to oxTrust.
It depends on the opiframe in oxauth working, so it should run on any Gluu with oxAuth#298 resolved. It depends on the same cryptoJS version that oxAuth uses.
The session tracking iframes call /identity/authentication/finishlogout (oxTrust's local logout) when session state is changed, so user has to click "sign in again" to reauthenticate.