Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CVSSv4 Calculator #387

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

domwhewell-sage
Copy link

Working PR to add CVSSv4 calculator onto the findings views as requested in #356.

The CVSSv4 calculator should appear as a optional tab once you click the "CVSS Calculator" accordion.
So as to minimize changes in future all Metrics are included.

@domwhewell-sage
Copy link
Author

The calculator at https://www.first.org/cvss/calculator/4.0 is slightly different to previous cvss versions in that it is being distributed as a vue.js application. https://github.com/FIRSTdotorg/cvss-v4-calculator

To avoid in inaccurate calculations by converting the vue.js app to javascript and mirror the existing cvss-v3 calculator it might make sense to fork the github project into the /static folder and display it within an iframe (Like first.org is doing). The only custom code will be extracting the final score and vector from the iframe and placing them into the cvss_score and cvss_vector fields.

@domwhewell-sage domwhewell-sage marked this pull request as ready for review February 4, 2024 16:58
@chrismaddalena chrismaddalena self-assigned this Feb 13, 2024
@felix-caboff
Copy link

Hi Team,

Is there anything I can do to move this particular pull request along? Not sure what your process is, whether you need someone to do some testing or similar. (We are desperate for it, don't worry if you have a plan, just trying to be helpful)

It looks like the CodeFactor checks failed because of the third-party library. I would suggest that these failures are ignored as that code is not a GW specific element.

Thanks!

@chrismaddalena
Copy link
Collaborator

@felix-caboff Once we wrap-up some features that have been in-flight for v4.1, we'll take a look at this. The big question is how easy it is for someone to choose the calculator they want to use. Some people still want CVSS v3. Others are asking for CVSS v3.1. Another group wants CVSS v4. The ideal end state is they're all available and you can pick which one to use.

In the meantime, checking out this PR and providing feedback is very helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants