Fix for getMaxUploadSize() #1325
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getMaxUploadSize() returns 0 when post_max_size is set to 0. It shouldn't do this, as setting post_max_size to 0 does not limit max post size, but actually removes maximum post limit altogether. From the php.ini: ; Maximum size of POST data that PHP will accept. ; Its value may be 0 to disable the limit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getMaxUploadSize() returns 0 when post_max_size is set to 0. It shouldn't do this, as setting post_max_size to 0 does not limit max post size, but actually removes maximum post limit altogether. From the php.ini:
; Maximum size of POST data that PHP will accept.
; Its value may be 0 to disable the limit.