fix(RichLabel): link focus #950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found while debugging a bug posted on Matrix:
In the 0.7 release, we introduced better keyboard navigation by remembering the last focused widget before showing a new timeline, and re-focusing when returning back. That way people using keyboard navigation won't have to start from the top.
GtkLabel is responsible for its links / we don't have access to them, not as widgets. That meant that it's also responsible for their focus, and clicking one of those links (notice: with a pointer device, not keyboard - that way it hasn't been in focus) wouldn't set it as focused and therefore when you went back to the previous timeline, it would start at the top.
Since timelines can only change when activating one of those links, the solution is to grab focus before handling the link. That way the previous timeline has the chance to update its last widget.