Simplify/restrict shortcut mods #4741
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Legitimate or not, we should not use sources that do not match the repository. Refs <libusb/libusb#1468 (comment)> Refs <https://news.ycombinator.com/item?id=39866309> Refs #4713 <#4713>
Restrict shortcut modifiers to be composed of only one item each. Before, it was possible to select a list of multiple combinations of modifier keys, like --shortcut-mod='lctrl+lalt,rctrl+rsuper', meaning that shortcuts would be triggered either by LCtrl+LAlt+key or RCtrl+RSuper+key. This was overly generic, probably not used very much, and it prevents to solve inconsistencies between UP and DOWN events of modifier keys sent to the device. Refs #4732 <#4732>
rom1v
force-pushed
the
simplify_shortcut_mods
branch
from
9f00458
to
21ae1ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restrict shortcut modifiers to be composed of only one item each.
Currently, it is possible to select a list of multiple combinations of modifier keys, like
--shortcut-mod='lctrl+lalt,rctrl+rsuper', meaning that shortcuts would be triggered either by LCtrl+LAlt+key or RCtrl+RSuper+key.This was overly generic, probably not used very much, and it prevents to solve easily inconsistencies between UP and DOWN events of modifier keys sent to the device.
For example, if
--shortcut-mod='lctrl+lalt', and the user successively performs the following actions:So an UP event is generated while no DOWN event is generated, which is inconsistent.
The problem is resolved with shortcuts modifiers of only 1 item (ignore the associated keycodes).
(EDIT: not all issues are solved though, it is still possible to generate a key down without the matching key up or vice-versa)
Refs #4732