Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #33, decrease bundle size by using lottie light #86

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

summerliu
Copy link

@summerliu summerliu commented Mar 22, 2023

My team ran into this issue #33 as well. The lottie bundle size was initially 3.81MB.(see image below)
lottie-react

And after implemented it with lottie light, it did reduced to 2.86MB.(also see image below)
lottie-react-light

This implementation could refer to https://github.com/dilan-dio4/lottie-light-react/commit/28c5bcbadcbc2b06dc92e0d2d1be1e20c64d5c1d#diff-0b5adbfe7b36e4ae2f479291e20152e33e940f7f265162d77f40f6bdb5da7405 by @dilan-dio4

Let me know if there is any question. Thanks!

Summer Liu added 2 commits March 21, 2023 13:54
# Conflicts:
#	build/index.d.ts
#	build/index.es.js
#	build/index.es.js.map
#	build/index.es.min.js
#	build/index.js
#	build/index.js.map
#	build/index.min.js
#	build/index.umd.js
#	build/index.umd.js.map
#	build/index.umd.min.js
@jorisw
Copy link

jorisw commented Feb 13, 2024

@Gamote Would you mind looking into this year old PR?

It would also remove this security concern:

Use of eval in "../../node_modules/lottie-web/build/player/lottie.js" is strongly discouraged as it poses security risks and may cause issues with minification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants