Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help center zh translation #1245

Closed
wants to merge 20 commits into from
Closed

Help center zh translation #1245

wants to merge 20 commits into from

Conversation

dawei-nava
Copy link
Contributor

@dawei-nava dawei-nava commented May 13, 2024

馃帿 Ticket

DO NOT MERGE

Link to the relevant ticket.
LG-13171

馃洜 Summary of changes

Help center zh translation change, based on #1233, merge after this.

@dawei-nava dawei-nava changed the title Dwang/help center zh temp Help center zh translation - DO NOT MERGE May 13, 2024
@daviddsilvanava
Copy link

Screenshot 2024-05-13 at 2 03 46鈥疨M @dawei-nava FAQ break is showing up above the "Don't" picture illustrations.

Will thread if I find anything else or when i'm done.

@daviddsilvanava
Copy link

Screenshot 2024-05-13 at 3 32 51鈥疨M Double check this string please. The google doc does not have a comma.

@dawei-nava
Copy link
Contributor Author

Screenshot 2024-05-13 at 3 32 51鈥疨M Double check this string please. The google doc does not have a comma.

This is based on https://docs.google.com/document/d/13uc-uIYDmpONjjeH-QLeXO7OF2DXMbkP6Ob-cKnKHRE/edit#heading=h.3jevs7eqegx9, which seems indicate that "tablet" will be used in some cases.
Screenshot 2024-05-14 at 9 27 04鈥疉M

@dawei-nava
Copy link
Contributor Author

Screenshot 2024-05-13 at 2 03 46鈥疨M @dawei-nava FAQ break is showing up above the "Don't" picture illustrations.
Will thread if I find anything else or when i'm done.

@daviddsilvanava, you are correct!

@juliaelman juliaelman self-requested a review June 7, 2024 17:13
@juliaelman juliaelman changed the title Help center zh translation - DO NOT MERGE Help center zh translation Jun 7, 2024
@juliaelman
Copy link
Member

Verified with @daviddsilvanava that this is approved to move forward, per approval from @benjaminchait.

@juliaelman
Copy link
Member

Verified content updates with @artfulaction.

@juliaelman
Copy link
Member

Closing this PR in favor of #1270

@juliaelman juliaelman closed this Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants