Some little changes to website #20
Conversation
Signed-off-by: Hendra Manudinata <[email protected]>
Updated on: December 12 2021 GMT+7. Signed-off-by: Hendra Manudinata <[email protected]>
Signed-off-by: Hendra Manudinata <[email protected]>
|
The Also, please don't merge for now! There's/re some more changes, but probably tomorrow. It's been 20:30, need rest from code. |
Reduce the headache of adding three lines just to add an admin. Note that this produces some dirty indentation in the built HTML because of the tags usage itself. Maybe need some workaround for this. Signed-off-by: Hendra Manudinata <[email protected]>
|
Let me know what you're thinking about this @ammarfaizi2 @irvanmalik48. |
All the detail should go into the patch itself, GitHub is just a side channel, it's perfectly fine to write it in the PR section, but the commit is more important than this PR thread. So put that explanation in the commit message. The git tree is the source of truth for figuring out why a particular change was done and needed. Not GitHub! |
| <li> | ||
| <a class="a-white" href="https://t.me/rin4th" | ||
| >@rin4th</a | ||
| > | ||
| </li> | ||
|
|
||
There was a problem hiding this comment.
You have extra trailing whitespace here.
There was a problem hiding this comment.
Yes, as mentioned in the commit.
The workaround is to add the for tags after the <ol> and </li> (endfor). But that'll make the source code ugly.
There was a problem hiding this comment.
There are more
Applying: sns: Correct `GitHub` spelling
Applying: home: Update Admin list
Applying: config: Drop unused `domain` variable
Applying: home: Use liquid `for` loop for admin list
.git/rebase-apply/patch:127: trailing whitespace.
.git/rebase-apply/patch:133: trailing whitespace.
.git/rebase-apply/patch:139: trailing whitespace.
.git/rebase-apply/patch:145: trailing whitespace.
.git/rebase-apply/patch:151: trailing whitespace.
warning: squelched 7 whitespace errors
warning: 12 lines add whitespace errors.
|
If we use an auto-generated admin list at all, the previous commit updating admin list is not needed, please drop that. |
Okay, I'll add it and repush. Sorry. |
You're right -- Dropping it after lunch. |
GitHubspelling.domainvariable.