New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix some comments #5680
fix some comments #5680
Conversation
@cuishuang I'm not sure why those tests failed. Please update your branch as it is now out of date. |
Thanks. Updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thanks for the PR. CI seems to be failing because you updated an error message but did not changed the test for that error message. So what you need to do make the pipeline green is changing the expected message at the related test.toml.
Modified. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Anything need I to do? Please feel free to tell me. |
Solve the merge conflicts and we should be able to merge this. |
Signed-off-by: cuishuang <[email protected]>
Solved, please review again. |
It's outdated again 😓 |
Updated! Please review again. |
The HEAD is moving pretty fast so it's outdated again, please check the box that allows edits by maintainers in this PR so that we can auto update it and it can be merged. |
02a00b4
55ffca4
to
de5fd6c
Compare
Signed-off-by: cuishuang <[email protected]>
Conflicts have been resolved and code updated. Since I forked the project to an organization rather than to my personal account, I couldn't see the "allows edits by maintainers" option. I tried a lot and finally checked the documentation and discussions and found that from fork to organization, the project does not have this feature. Even though I created this organization and am the only member. https://github.com/orgs/community/discussions/5634 Sorry for causing this trouble. If the problem still cannot be solved, I can close this PR, fork it to my personal account, and submit a new PR. Waiting for your reply and decision |
I'm going to close this PR, please reopen one with a personal account fork and we'll get this merged. |
Thanks. The new pr #5989 The new pr allow edits by maintainers, Please review again. |
Description
Checklist
Breaking*
orNew Feature
labels where relevant.