New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add log type info collection for test entries to enable log decoding at forc-test #5678
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kayagokalp
added
enhancement
New feature or request
forc-test
Everything related to the `forc-test` lib and `forc test` command.
forc-pkg
Everything related to the `forc-pkg` crate.
labels
Mar 2, 2024
2 tasks
Benchmark for 5ad8bc8Click to view benchmark
|
sdankel
reviewed
Mar 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work! Just a few nits.
Benchmark for 3fccf68Click to view benchmark
|
kayagokalp
force-pushed
the
kayagokalp/log-decoding
branch
from
March 5, 2024 23:53
ada8f0f
to
90d31eb
Compare
Benchmark for e502aebClick to view benchmark
|
Benchmark for fcc2e69Click to view benchmark
|
Benchmark for e08123dClick to view benchmark
|
sdankel
approved these changes
Mar 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! 💯
Benchmark for 3ea7c87Click to view benchmark
|
JoshuaBatty
approved these changes
Mar 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Benchmark for cc22fc1Click to view benchmark
|
Benchmark for 1f82760Click to view benchmark
|
Benchmark for 6a1653eClick to view benchmark
|
Benchmark for f9a0a37Click to view benchmark
|
Benchmark for 3c64401Click to view benchmark
|
closed in favor of #5812 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
forc-pkg
Everything related to the `forc-pkg` crate.
forc-test
Everything related to the `forc-test` lib and `forc test` command.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds necessary capabilities to forc-pkg to collect types of
log
s used in a test. Type information is retrieved from the type engine, and collected for each test entry. This will later on be used for decoding the log receipts at forc-test.