fix: getting started routing not working on other path structures #1288
+10
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes button not working on docker hub
arthurgeron
requested review from
luizstacio,
pedronauck,
LuizAsFight and
helciofranco
as code owners
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟡 | Statements | 62.47% | 3228/5167 |
| 🔴 | Branches | 41.91% | 627/1496 |
| 🔴 | Functions | 46.94% | 682/1453 |
| 🟡 | Lines | 63.03% | 3110/4934 |
Test suite run success
240 tests passing in 70 suites.
Report generated by 🧪jest coverage report action from 265d390
helciofranco
approved these changes
May 13, 2024
LuizAsFight
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
Wallet's Docs use a base path for all the routes, so if the base route is
http://localhost:3030/docs/dev/, thenGetting Startedpage is going to behttp://localhost:3030/docs/dev/getting-started/.The problem:
The problem with the current approach is that it'd push the entire path, so to change from
getting startedto install it'd need to push/docs/dev/install/, which is problematic because it isn't agnostic to the base path, which will change with implementations such as the one in the docs hub.Solution:
Assume the base path from the current path in install page, so for
http://localhost:3030/docs/dev/install/it'd calculate the base path to behttp://localhost:3030/docs/dev/, appending the new Wallet Docs path to the end of that base, which essentially makes it agnostic regarding the base path, fixing the behavior of that route navigation in Docs Hub.