feat: add advanced fees when approving a request #1277
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helciofranco
requested review from
luizstacio,
pedronauck and
LuizAsFight
as code owners
Base automatically changed from
hf/feat/advanced-fees
to
lf/feat/upgrade-fuels-core-0.24
May 7, 2024 17:41
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟡 | Statements | 62.58% | 3264/5216 |
| 🔴 | Branches | 42.01% | 634/1509 |
| 🔴 | Functions | 47.24% | 692/1465 |
| 🟡 | Lines | 63.13% | 3146/4983 |
Test suite run success
240 tests passing in 70 suites.
Report generated by 🧪jest coverage report action from ca56339
helciofranco
force-pushed
the
hf/feat/advanced-fees-2
branch
from
61e3e23
to
ca56339
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the
Custom Feesfeature from theSend Transactionscreen, enabling users to set a custom fee when approving a request from a Dapp.Screen.Recording.2024-05-06.at.13.58.35.mov