Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore!: hotfix PR for connectors, will be removed #2224

Closed
wants to merge 3 commits into from
Closed

chore!: hotfix PR for connectors, will be removed #2224

wants to merge 3 commits into from

Conversation

nedsalk
Copy link
Contributor

@nedsalk nedsalk commented May 3, 2024

No description provided.

@fuel-service-user
Copy link
Contributor

fuel-service-user commented May 3, 2024 •
edited

✨ A PR has been created under the rc-2224 tag on fuels-wallet repo.
FuelLabs/fuels-wallet#1269

@arboleya arboleya added the chore label May 3, 2024
@arboleya arboleya marked this pull request as draft May 3, 2024 16:56
arboleya
arboleya reviewed May 3, 2024
View reviewed changes
Copy link
Member

@arboleya arboleya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Converted to draft, as it's not meant to be merged.

@nedsalk
Copy link
Contributor Author

nedsalk commented May 5, 2024

Closing because it served its purpose.

@nedsalk nedsalk closed this May 5, 2024
@nedsalk
Copy link
Contributor Author

nedsalk commented May 5, 2024

@arboleya I had to create it as non-draft because the automatic workflow only publishes "ready for review" PRs.

@arboleya arboleya deleted the hotfix-for-connectors branch May 5, 2024 11:26
@arboleya
Copy link
Member

arboleya commented May 5, 2024 •
edited

@nedsalk Thank you.

Are you sure non-draft PRs are not published?

I may be missing something, but I failed to find such a conditional/distinction in the code.

@nedsalk
Copy link
Contributor Author

nedsalk commented May 5, 2024

@arboleya I was relying on this automatic workflow initially which has that conditional.

@arboleya
Copy link
Member

arboleya commented May 5, 2024

Got it. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arboleya arboleya arboleya left review comments

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@Torres-ssf Torres-ssf Awaiting requested review from Torres-ssf Torres-ssf is a code owner

@Dhaiwat10 Dhaiwat10 Awaiting requested review from Dhaiwat10 Dhaiwat10 is a code owner

@danielbate danielbate Awaiting requested review from danielbate danielbate is a code owner

@petertonysmith94 petertonysmith94 Awaiting requested review from petertonysmith94 petertonysmith94 is a code owner

@maschad maschad Awaiting requested review from maschad maschad is a code owner

Assignees

@nedsalk nedsalk

Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nedsalk @fuel-service-user @arboleya @LuizAsFight