New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove prettier
and eslint
in favour of biome
#2219
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe I'm missing something but is this not removing all the rules we currently have in place? I can't see a biome.json
file which has all the rules migrated from eslint
👀
Also for the apps
and templates
, I believe these should be self sufficient. So maybe, we should add biome
as a devDependency and add the relevant configuration files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I second what @petertonysmith94 said. If we are swapping libraries, it must be a drop-in replacement.
Also, do we really want to push biome on others via the create-fuels
template? I haven't thought much about it, but my instinct says we should not.
Agreed @arboleya and @petertonysmith94 the intention is to migrate the rules over, this initial step was just removing eslint. Once that migration is complete I think the PR will be ready for review. I appreciate the initial feedback on PR especially since it touches so many files. |
Thanks for the first pass @nedsalk , a lot of these were actually bugs hence the compilation issues. I've addressed them, I'll open the PR for review when ready. |
prettier
and eslint
in favour of biome
I think this project would be good to revisit in the future but I don't think it's worth the change yet based on reasons listen in the description. |
Closes #2195
Pros
Biome
would centralize all ourlinting
andformatting
into one file i.e. thebiome.json
Biome
is ~15x faster than ESLint and ~20x than prettierCons