Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: re-enable dev connector in create-fuels template #2210

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Dhaiwat10
Copy link
Member

Closes #2171

I know... another one-line PR 馃し馃徎

Copy link
Contributor

@nedsalk nedsalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If only all PRs were one-liners!

Copy link
Contributor

@petertonysmith94 petertonysmith94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assume we'll wait for @fuels/connectors has been updated?

Copy link
Contributor

@Torres-ssf Torres-ssf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, is it possible to uncomment this already?

Is the connectors package using fuels 0.83 already?

@arboleya
Copy link
Member

The relationship between fuels and @fuels/connectors looks problematic.

Because one depends on the other, their cyclic dependency should always hunt us and delay releases.

Copy link
Contributor

github-actions bot commented May 6, 2024

Coverage Report:

Lines Branches Functions Statements
79.53%(+0%) 69.28%(+0%) 77.43%(+0%) 79.65%(+0%)
Changed Files:

Coverage values did not change馃憣.

@petertonysmith94
Copy link
Contributor

The relationship between fuels and @fuels/connectors looks problematic.

Because one depends on the other, their cyclic dependency should always hunt us and delay releases.

You are right here.

I suppose we have a number of options:

  1. Install the dependency + integrate on bootstrap (not sure how viable this is).
  2. Remove the @fuels/connectors dependency entirely.
  3. Move templates to a new repository (possibly with create-fuels).

Any others that I've missed?


I'd say that after #2170 has been completed, we'll be in a better position to gauge whether option 1 is viable.

@Dhaiwat10
Copy link
Member Author

Dhaiwat10 commented May 9, 2024

I just checked. There is indeed a version mis-match here. Marking this as blocked until the wallet SDK bumps their TS SDK version

@Dhaiwat10 Dhaiwat10 marked this pull request as draft May 9, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update template use of connectors
6 participants