Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: warn on fuel client version incompatibility #2209

Merged
merged 19 commits into from May 5, 2024
Merged

chore: warn on fuel client version incompatibility #2209

merged 19 commits into from May 5, 2024

Conversation

nedsalk
Copy link
Contributor

@nedsalk nedsalk commented Apr 30, 2024 •
edited

Similar to what was done on fuels-rs here.

closes #2207

@nedsalk nedsalk added the chore label Apr 30, 2024
@nedsalk nedsalk self-assigned this Apr 30, 2024
@fuel-service-user
Copy link
Contributor

✨ A PR has been created under the rc-2209 tag on fuels-wallet repo.
FuelLabs/fuels-wallet#1260

arboleya
arboleya reviewed Apr 30, 2024
View reviewed changes
Copy link
Member

@arboleya arboleya left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although the behavior changes a bit, perhaps it could be a patch since it doesn't break the API.

.changeset/soft-knives-sit.md Outdated Show resolved Hide resolved
@nedsalk nedsalk changed the title chore!: warn on fuel client version incompatibility chore: warn on fuel client version incompatibility Apr 30, 2024
arboleya
arboleya previously approved these changes Apr 30, 2024
View reviewed changes
maschad
maschad previously approved these changes Apr 30, 2024
View reviewed changes
danielbate
danielbate previously approved these changes May 2, 2024
View reviewed changes
arboleya
arboleya previously approved these changes May 2, 2024
View reviewed changes
@arboleya arboleya dismissed Dhaiwat10’s stale review May 2, 2024 17:56

Your request has been addressed.

@nedsalk nedsalk dismissed stale reviews from arboleya and danielbate via fa32161 May 3, 2024 08:42
@nedsalk nedsalk enabled auto-merge (squash) May 3, 2024 08:42
arboleya
arboleya previously approved these changes May 3, 2024
View reviewed changes
Torres-ssf
Torres-ssf previously approved these changes May 3, 2024
View reviewed changes
maschad
maschad requested changes May 3, 2024
View reviewed changes
Copy link
Member

@maschad maschad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grammar pedant 🤓

packages/account/src/providers/provider.test.ts Outdated Show resolved Hide resolved
packages/account/src/providers/provider.test.ts Outdated Show resolved Hide resolved
packages/account/src/providers/provider.ts Outdated Show resolved Hide resolved
@nedsalk nedsalk dismissed stale reviews from Torres-ssf and arboleya via 421f208 May 5, 2024 07:30
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 5, 2024

Coverage Report:

Lines Branches Functions Statements
79.53%(+0%) 69.28%(+0%) 77.43%(+0%) 79.65%(+0%)
Changed Files:

Coverage values did not change👌.

maschad
maschad approved these changes May 5, 2024
View reviewed changes
Copy link
Member

@maschad maschad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nedsalk nedsalk merged commit f7eacb4 into master May 5, 2024
19 checks passed
@nedsalk nedsalk deleted the ns/feat/soft-warnings-for-incompatible-errors branch May 5, 2024 23:02
@fuel-service-user fuel-service-user mentioned this pull request May 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arboleya arboleya arboleya approved these changes

@maschad maschad maschad approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@Dhaiwat10 Dhaiwat10 Awaiting requested review from Dhaiwat10 Dhaiwat10 is a code owner

@danielbate danielbate Awaiting requested review from danielbate danielbate is a code owner

@petertonysmith94 petertonysmith94 Awaiting requested review from petertonysmith94 petertonysmith94 is a code owner

@Torres-ssf Torres-ssf Awaiting requested review from Torres-ssf Torres-ssf is a code owner

Assignees

@nedsalk nedsalk

Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use soft warnings for node incompatible versions
8 participants
@nedsalk @fuel-service-user @arboleya @danielbate @maschad @petertonysmith94 @Torres-ssf @Dhaiwat10