-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: update deps #2158
build: update deps #2158
Conversation
With the Do we have a list of the breaking changes for the other packages updated? |
The |
@danielbate @Torres-ssf can you let me know if you are still experiencing performance issues on this? it should be fine now. |
I had no issues running the tests using this branch |
Just merged
There are also a lot of warnings within the
|
aedc1b8
to
8c1c139
Compare
Good catch @petertonysmith94 , it seems my previous lockfile was causing vitest to run v1.5 despite those deps not being updated to that vitest version, a bit strange considering that's outside the semver range, I must have forgotten to run pnpm install ... nevertheless I've resolved that and the warnings and flakey test are gone now 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maschad that is odd, potentially we need to add --frozen-lockfile
to the pnpm install
for our CI environment?
Either way, this looks good now 🥳
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good one! 💪
I just tested this branch locally, and everything went well.
Please remember to double-check it after it goes to master
. 🙂
Coverage Report:
Changed Files:
|
I explained here the rationale for re-opening this.
This undoes the revert done here I chose to use the original branch as a revert of a revert would make the commit history look less readable.
I've ran these tests in the browser at least 4 times with no failures so I think it's safe to merge.