New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: optionally auto-install fuelup
during create fuels
routine
#2149
Conversation
This PR is published in NPM with version 0.0.0-pr-2149-20240427110619 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job! I think we want to guide users a bit more on the process though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add some tests?
@arboleya That wouldn't be a bad idea. What should we test? That the |
@Dhaiwat10 You can mock
You'll also have to mock |
@nedsalk Exactly. 👌 @Dhaiwat10 The idea is to validate that conditionals, prompts, and warnings/errors are all working correctly. The coverage report can help you understand the parts of the code that aren't under test and target those. You might have to mock As integration tests may not fit here, you could also unit-test functions in isolation. |
I think we are safe to merge this one since @petertonysmith94 kindly went ahead and added a comprehensive suite of tests for the tool when I was away last week: #2237 |
Coverage Report:
Changed Files:
|
Summary
This PR adds a new feature to the
create-fuels
CLI tool which detects if the user has already installedfuelup
or not. If the user does not havefuelup
installed, it gives the users the choice to let the tool installfuelup
for them.Closes #2099