Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sticky buttons #6304

Merged
merged 22 commits into from
Jun 12, 2024
Merged

Sticky buttons #6304

merged 22 commits into from
Jun 12, 2024

Conversation

math-GH
Copy link
Contributor

@math-GH math-GH commented Apr 14, 2024

Inspired by #6014
Pre-work done by #6202

Keep the submit button always reachable.

have a look onto the logs
grafik

have a look onto the feed configuration
grafik

How to test the feature manually:

  1. go to display option and enable the sticky buttons (last option)
  2. see the sticky buttons at the bottom of window

Pull request checklist:

  • clear commit messages
  • code manually tested

@math-GH math-GH added this to the 1.25.0 milestone Apr 14, 2024
@math-GH math-GH added UI 🎨 User Interfaces UX User experience labels Apr 16, 2024
@math-GH math-GH marked this pull request as ready for review April 16, 2024 14:09
@Alkarex
Copy link
Member

Alkarex commented Jun 5, 2024

I think we should just make the new behaviour the default, without new option (I would like to limit the number of options, as it increases the amount of tests and translations and complexity)

@math-GH
Copy link
Contributor Author

math-GH commented Jun 11, 2024

I think we should just make the new behaviour the default, without new option (I would like to limit the number of options, as it increases the amount of tests and translations and complexity)

reverted ✅

@Alkarex
Copy link
Member

Alkarex commented Jun 12, 2024

Nice work! 👍🏻

@Alkarex Alkarex merged commit 35ee123 into FreshRSS:edge Jun 12, 2024
2 checks passed
@math-GH math-GH deleted the sticky-buttons branch June 12, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI 🎨 User Interfaces UX User experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants