Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Referrer-Policy: same-origin #6303

Draft
wants to merge 3 commits into
base: edge
Choose a base branch
from

Conversation

math-GH
Copy link
Contributor

@math-GH math-GH commented Apr 14, 2024

@math-GH math-GH added this to the 1.24.0 milestone Apr 14, 2024
@Alkarex
Copy link
Member

Alkarex commented Apr 14, 2024

  1. I am not sure disabling Referer is a good idea for the ecosystem. The default behaviour (strict-origin-when-cross-origin) seems better to me
  2. In this PR, the main place where this would be relevant (the main view) is not addressed for setups not using our default .htaccess (e.g. people insisting on using nginx). We should compare with the way we define Content-Security-Policy in PHP

@Alkarex Alkarex modified the milestones: 1.24.0, 1.25.0 Apr 15, 2024
@math-GH
Copy link
Contributor Author

math-GH commented Apr 15, 2024

  1. I am not sure disabling Referer is a good idea for the ecosystem. The default behaviour (strict-origin-when-cross-origin) seems better to me

I personally prefer same-origin because of this:
grafik

same-origin keeps my very private used server and its URL privat. The target server thinks I am visiting the article directly.
strict-origin-when-cross-origin will tell the target server where I come from.

2. In this PR, the main place where this would be relevant (the main view) is not addressed for setups not using our default `.htaccess` (e.g. people insisting on using nginx). We should compare with the way we define `Content-Security-Policy` in PHP

I took the same lines of Content-Security-Policy in PHP and .htaccess
Have I have overseen a line?

@Frenzie
Copy link
Member

Frenzie commented Apr 15, 2024

Perhaps it makes sense in config.default.php or similar? I'm probably more sympathetic to the no referrer point of view myself, but it's definitely a thing where you can imagine people wanting more of a "website" behavior than an "app" behavior.

@math-GH math-GH marked this pull request as draft May 23, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants