Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SimplePie workaround for Atom cdata type bug #6181

Open
wants to merge 2 commits into
base: edge
Choose a base branch
from

Conversation

Alkarex
Copy link
Member

@Alkarex Alkarex commented Mar 8, 2024

Accept feeds with wrong <content type="CDATA"> instead of <content type="html">
fix #6180

Accept feeds with wrong `<content type="CDATA">` instead of `<content type="html">`
fix FreshRSS#6180
Copy link
Member

@Frenzie Frenzie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to ask if that's really necessary, but then I saw your comment about the library. Should it give some kind of log warning for that case though?

@Alkarex
Copy link
Member Author

Alkarex commented Mar 8, 2024

I am more pondering whether this should be merged at all or not. There are many other types of bugs we are coping with, without a log entry. This is more a role for a feed validator. If the source bug is actually lkiesow/python-feedgen#123, it might soon be less relevant (assuming people are updating their libraries...)

@Frenzie
Copy link
Member

Frenzie commented Mar 9, 2024

Yes, not merging it makes sense to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]The subscription source has garbled characters.
3 participants