Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Change default UMF colors for better contrast #13781

Merged
merged 1 commit into from May 6, 2024

Conversation

maxwxyz
Copy link
Collaborator

@maxwxyz maxwxyz commented May 2, 2024

Default colors of the new unified measurement tool are hard to see on either light or dark themes:
324229416-0060c681-bb31-4759-a601-02c8879de45f
325056262-af178977-32d2-4575-bfc0-153bb0a5275d

This PR sets line and background color to a green which is visible on most themes. Contrast ratio between annotation text and text background is 13.65:1

After:
image

@chennes
Copy link
Member

chennes commented May 2, 2024

Others from @FreeCAD/design-working-group OK with this change?

@obelisk79
Copy link

As a default this is likely ok. However using primary shades of colors is not a great idea. Are these colors configurable by themes?

@maxwxyz
Copy link
Collaborator Author

maxwxyz commented May 2, 2024

yes you can configure them, I've an issue in OpenTheme about this.

@pierreporte
Copy link

The measurements are perfectly readable with the default theme. Is this an issue for the other official themes?

This being said, considering that the color can be set by the theme, I think that we should chose the right color for all of them. Green looks good, especially if we turn all sketch dimension green (as I proposed on other issues).

image

@Reqrefusion
Copy link
Contributor

Green is suitable, but is this green really appropriate? It would be better if one of the Chameleon colors specified in the current design guide was used. #73d216 seems suitable for this job.

@sliptonic sliptonic merged commit 302a202 into FreeCAD:main May 6, 2024
10 checks passed
@maxwxyz maxwxyz deleted the umf-colors branch May 6, 2024 16:17
adrianinsaval pushed a commit to Ondsel-Development/FreeCAD that referenced this pull request May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants