Core: Document getRootObjects : Fix bug of objects linked not returned. #13780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Core
|
Set as draft waiting discussion to resolve. |
…mblyObject.cpp, CommandInsertLink.py, UtilsAssembly.py
|
It appears that RootObjects are the 'dependency-free objects that are in this document' and not 'root objects of the document' ie the tree-root level objects as one would most likely expect. So even though it appears nothing in the code base is using RootObjects in this original sense, instead of fixing
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a root object has a link pointing to it, then it is not returned by RootObjects.
Having a look at the function in cpp it seems to be because its checking if the inList is empty to determine if its a root object.
https://forum.freecad.org/viewtopic.php?p=756837#p756837