Update icons for legibility and consistency #13769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Core
|
Must have changes, congratulations. Some of them very critical(redo,undo). |
|
Nice icon enhancements as always. But maybe the Undo and Redo icons could be highlighted even more? What about a different color like blue? Yellow is less conspicuous. |
|
I've kept the colors as is. Refresh is blue already and right next to it. |
|
It would be much better if you resize the icons here according to the keyline. |
It doesn't have to be blue. Maybe green, orange, or other well-visible shade. Just to make those important icons stand out more. |
|
I'm going to merge as-is, since this is an improvement. If there are other changes to be made please submit a new PR. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slight update of some icons for better legibility and consistency (follow current artwork guidelines).
Example: Redo icon has currently not a good contrast in grayed out and active state:
