Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AddonManager: Changing the stop icon from green to red #13766

Merged
merged 1 commit into from May 3, 2024

Conversation

maxwxyz
Copy link
Collaborator

@maxwxyz maxwxyz commented May 1, 2024

fixes #13563

Using a red square icon instead of a green one.
@chennes FYI

@chennes chennes self-assigned this May 1, 2024
@maxwxyz
Copy link
Collaborator Author

maxwxyz commented May 1, 2024

@chennes alternatively there is also process-stop.svg in the same directory, maybe that is also a good fit (but it is also used for the close button in the addon manager).
image

@Reqrefusion
Copy link
Contributor

Something more circular will be made for the Close button, which can be used for the purpose here. An octagonal icon seems more appropriate to stop than to close.

@chennes
Copy link
Member

chennes commented May 1, 2024

No strong preference here: whatever @FreeCAD/design-working-group wants to go with, I'll merge.

@MisterMakerNL
Copy link
Contributor

Cross is close or cancel, square is stop.
We all know this from our video players. 😉
If you press this button does it saves the already loaded data? If so I'd see it as a stop button.
If you'd lose all already read data it's a cancel button.

@maxwxyz
Copy link
Collaborator Author

maxwxyz commented May 2, 2024

OK, then I'll leave the PR as is :)

@chennes
Copy link
Member

chennes commented May 2, 2024

If you press this button does it saves the already loaded data? If so I'd see it as a stop button.

It's a mix: the startup process is really six or seven independent processes. You will be cancelling the process that is running at the moment you click the button, but will be preserving the data obtained in any step that ran to completion prior to your click.

@chennes chennes merged commit f74bfc4 into FreeCAD:main May 3, 2024
10 checks passed
@maxwxyz maxwxyz deleted the addon-manager-stop-icon branch May 7, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

addon manager: stop refresh button is a green square
4 participants