-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft: Add "legacy importer only" to DXF option #13638
Draft: Add "legacy importer only" to DXF option #13638
Conversation
@Roy-043 thanks! I think there are stilll more capabilities in the preferences dialog that are legacy-importer-only. I wonder if there is a more concise way to mark them without appending the ("legacy importer only") string to them. I did a side by side comparison table here: #13599 (comment) Here's a mockup of what I had in mind: Conceivably, a better implementation would be to disable the relevant options when the Use legacy python exporter checkbox is ticked. However, as a first iteration, just marking those options would already go a long way preventing user confusion and spending time in trial-and-error importer passes. Those can take a quite a long time depending on the imported file's complexity, and the options chosen. |
Thanks for the detailed analysis. It is indeed better to do this properly. I'll convert this PR to Draft for now. If I remember correctly there may even be a setting that affects both import and export... |
Thank you. I just finished the analysis and updated the original comment. The comparison table is now up-to-date to the best of my knowledge. |
Related: #13751 |
Legacy only items are en/disabled depending on the selected legacy options. The "Some options are not yet available for ..." texts are in italics.
This is excellent, thanks so much. This removes the previous uncertainty, it will make life easier and it will prevent unnecessary trial and error trying combinations of unimplemented options. Some other comments:
|
Does this PR need further testing or review before getting merged? Thanks. |
The |
Makes sense, thanks! |
Fixes #13598.