Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support US3000 batteries as master #5

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

Frankkkkk
Copy link
Owner

Still not merging because I'm not really happy with the construct structure: it would be way better to override the field with the US3000 values so that the API doesn't change...

@hrford
Copy link

hrford commented Feb 20, 2022

Hey Frank,
I have a Pylontech US3000 at a gliding club, on top of a hill, in the South West of the UK. I also dev in Python and have your library talking to the US3000.
I see this PR and would like to assist where possible.
At the present time I'm seeing what looks like null/empty values in this return:
RemainingCapacity = 65.535
TotalCapacity = 65.535
CycleNumber = 133
TotalPower = -173.5965
StateOfCharge = 1.0

I'm happy to run test code with you to get these fields working on a US3000. I'm assuming this PR goes some way to fixing this issue, or perhaps they're not related?
Thanks, Henry

@hrford
Copy link

hrford commented Mar 27, 2022

@Frankkkkk Hey, do you have any thoughts on getting the API to be happy with US3000 values? Do you think it'd need an API change? Perhaps through versioned calls or would you think overriding the fields would be more straightforward? I'd like to work on getting US3000 capacity up and running for our unit. :)

@hrford
Copy link

hrford commented Apr 17, 2022

Have you considered using construct.If to override the API's field StateOfCharge with US3000 values, if they exist? Much like you do in this PR with UserDefinedItems > 2? If not, I'll create a PR if I can do it cleanly.

@Frankkkkk
Copy link
Owner Author

Hi @hrford If you have an MR for improving mine I'd happily take it :-)

@hrford
Copy link

hrford commented Jul 28, 2022

@Frankkkkk I've not forgotten this, life is in the way and I've not installed any remote equipment at the club yet. I have some code which I used keeping in the fashion that you've been doing, I didn't change the API naming to achieve it either :)

So will get a PR in when I can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants