Cue Settings Panel #79
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cue settings are now displayed in a foldable panel. Almost no modification on existing settings page code Only implemented on ListLayout. The area where running cues are displayed is also foldable
Yinameah
force-pushed
the
info_cue_in_panel_v2
branch
from
54fecf1
to
8737f76
Compare
Add record mechanism with apply button A signal as been added in lisp/cues/cue.py so the setting panel can be notified when changes are done by SettingsDialog
Yinameah
force-pushed
the
info_cue_in_panel_v2
branch
4 times, most recently
from
d4ca297
to
96d74be
Compare
Add horizontal splitter for each page, give custom default sizes Cleaned fold logic and add autoresize when folding Mapped Return_key to save settings faster
Yinameah
force-pushed
the
info_cue_in_panel_v2
branch
from
96d74be
to
c90bee8
Compare
Simple implementation of CueSettingPanel in CartLayout with a new "intermediate" class for minimal modification + dicsconnect cue modification signal when modification comes from the panel itself
Yinameah
force-pushed
the
info_cue_in_panel_v2
branch
from
aa19d85
to
83b6e48
Compare
|
I've done some serious progress. The use of an Apply button allowed me to be very close of the Dialog Setting mechanism and both work alongside. Better usability could certainly be achieved, but at the cost of rewriting a lot the settings pages themselves to be more automatically linked to properties. For the time being, it is a good middle path how already enhance the workflow speed by a long shot. Anyone are welcome to test tracking for bugs... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework of my cue setting panel.
CueSettingsWidgets are re-instanciated each time so it's closer to current implementation.
Try to work with an apply button since auto record is really more complicated and need lots of modification on settings pages themselves.