Added Gujarati language layout

[Abcd1234-dot]

What is it?

• Bugfix
• Feature
• Codebase improvement

Description of the changes in your PR

• Added Guajarati Language Layout. Make sure that there's no syntax error. I can't compile source code to apk, so it would be nice if you provide compiled apk with these changes to test.

Fixes the following issue(s)

• Fixes Add Gujarati language layout #22

Acknowledgement

• I read the contribution guidelines.

[Aga-C]

This string doesn't exist. You should add it in Commons in https://github.com/FossifyOrg/Commons/blob/master/commons/src/main/res/values/strings.xml. When creating a pull request in Commons, please mention that it's for this one.

[Abcd1234-dot]

So, I just have to add similar line there?? That's it? I created PR there too.

[Aga-C]

It's ok now.

[Abcd1234-dot]

Please provide compiled apk to test when you finish these changes.

[naveensingh]

@kumarayush2104 Hi! Do you know some Gujarati? If yes, can you test the suggested changes in this PR?

[kumarayush2104]

@naveensingh I will test and provide you results as soon as possible

[kumarayush2104]

@Abcd1234-dot @naveensingh Sorry for the delay.

There are many problems in this pull request:

1. Try writing some words which uses half consonants like Sneha. You will not be able to write it.
2. Try writing some words which start with vowels like Ayush, Astha, Unnati. You will not be able to write them.
3. Users face difficulty in finding consonants after થ, like they have to hold each button to find consonants.

[Abcd1234-dot]

@kumarayush2104 Thank you for your testing. Here are my thoughts :

• I already mentioned pop up keys issue in issue Add Gujarati language layout #22, it is more convenient to use shift key as page 1/2 key as there are many characters to fit into the layout and it is really a hassle to write with pop-up characters every time. I have also added gujarati language recently into OpenBoard helium314 fork and there was already a shiftkey status selector, so there will be different characters for shift ON and shift OFF state. That would be a good way to solve this pop up keys issue. But its up to developers.
• I am not sure why you can not write half alphabets. You have to add " ્" (which you can find at the right bottom of keyboard) after that specific character to make it half character just like in case of Sneha (સ + ્ + ન + ે + હ + ા)
• I have also added every vowel into pop up keys as well, so there should be no issue writing any vowel as well. You just need to find it into pop-ups. Another issue with the pop-up is, user can't see what is the pop-up key without try to long press, like there should be a hint or something as it is present for number row, numbers are visible as small hints on the first row of characters when number row is off which can be accessible via pop-ups.

[naveensingh]

Sorry, closed it accidentally as a result of FossifyOrg/Commons#30

[naveensingh]

@Abcd1234-dot I resolved the conflicts and fixed some layout issues. I also removed the (unused) shift button from the Gujarati layout so you can fit in more characters on the bottom line if you want to. I don't speak the language myself so here's an APK:

keyboard-fdroid-release.zip (GitHub doesn't support APKs, rename to keyboard.apk and install)

[Abcd1234-dot]

@naveensingh Thank you!! I will revert you back within short time.

Alright i tested the apk file you just tagged in previous reply. It is still very difficult and inconvenient to fit all characters properly within the space (even with no shift key!) (so either we have to use long press to pop-up which is not good for typing at all as @kumarayush2104 described or we can try the change i am proposing). So I propose a change in keyboard!! Rather than removing shift key, can we use it as "page 1/2" key?? Just like shift ON shows capital letters and shift OFF shows small letters (For English language), we can make shift key to show one set of (Gujarati) letters for ON state and another set of (Gujarati) letters for OFF state. This will solve similar "too many alphabets" issue for all languages permanently. I have added Gujarati Language to HeliBoard keyboard (another open source keyboard for android, fork of Openboard) with same functionality. I attach screenshots of Heliboard with Gujarati Language below (you can see how many characters to fit!!!).

For Shift ON

For Shift OFF

[naveensingh]

Rather than removing shift key, can we use it as "page 1/2" key??

Yes but creating paged layouts will require some code restructuring. I'll be back to this after the initial release.

[tenextractor]

@Abcd1234-dot Wouldn't it be better to follow the InScript standard with some modifications to make it mobile-friendly, instead of creating a different layout?