feat: upgrade expo, RN, and Skia (and deps) #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 80e45df The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
zibs
changed the title
carbonrobot
approved these changes
May 9, 2024
|
I'm noticing a fairly easy to reproduce crash with Skia here on the Stock chart demo -- gonna see if I can reproduce on main before proceeding here |
|
Okay, the latest commits seems to have fixed the crash I was seeing! |
removes reanimated plugin removes android/ios bumps to latest version packages
I don't think this was ever supported internally by the code... And the slightly different signatures of each call makes it so we have to add type guards so that TS can properly infer the args
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bumps Expo, RN and RNSkia in preparation for Expo's next release. This will let us bump our minimum supported Skia version so that we can use a few new APIs and features now that RNSkia has hit 1.0.
This also gitignores the
/androidand /iosfolders we were using previously. Now, if one wants to prebuild or add custom functionality, they can do that while testing more easily. This should keep things a bit simpler.Will also need FormidableLabs/react-native-dark#8 to land tooType of Change
How Has This Been Tested?
Checklist: (Feel free to delete this section upon completion)
yarn run check:codeand all checks pass