Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update codecov versions #4

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update codecov versions #4

wants to merge 1 commit into from

Conversation

CarloLucibello
Copy link
Member

Let's see if I managed to successfully setup codecov for this repo

@CarloLucibello
Copy link
Member Author

It didn't work 😢
I don't know what I did wrong, I followed the instructions
https://app.codecov.io/gh/FluxML/SafeTensors.jl/new

@chengchingwen
Copy link
Member

I think you also need to install codecov for this repo https://github.com/apps/codecov

@CarloLucibello
Copy link
Member Author

It seems installed... I don't know what else to do. @ToucheSir any idea?

@ToucheSir
Copy link
Member

According to https://app.codecov.io/gh/FluxML/SafeTensors.jl/new (needs login with GitHub first), we need to commit this config to the main branch first.

Also, they recommend this config:

- name: Upload coverage reports to Codecov
  uses: codecov/[email protected]
  env:
    token: ${{ secrets.CODECOV_TOKEN }}
    slug: FluxML/SafeTensors.jl

Should we add the slug field?

Also also, should we make the CODECOV_TOKEN an org-wide secret like https://discourse.julialang.org/t/psa-new-version-of-codecov-action-requires-additional-setup/109857 suggests? We basically have to repeat this process for every repo that currently uses CodeCov.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants