Improve snapshot actions across devices, instances and applications #3885

Steve-Mcl · 2024-05-17T16:30:37Z

closes #3815
closes #3629

Description

Squares up the kebab menus of snapshot views (see caveats)
- including renaming rollback to "Deploy Snapshot" (see Proposal to Rename 'Rollback' to 'Deploy Snapshot' #3629)
Provides missing feature Download Snapshot and Download Package.json for devices
- This was dependant on prior works Snapshots api #3833

Caveats

Some menu items do not make a sense on other views and thus not all menus are the same. This was discussed and agreed in the issue comment

TODO:

tests - done
check see if there is anywhere docs should be updated - done
changelog entry : Changelog entry for snapshots... website#2079

Related Issue(s)

Checklist

I have read the contribution guidelines
Suitable unit/system level tests have been added and they pass
Documentation has been updated
- Upgrade instructions
- Configuration details
- Concepts
Changes flowforge.yml?
- Issue/PR raised on FlowFuse/helm to update ConfigMap Template
- Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

Includes a DB migration? -> add the area:migration label

codecov · 2024-05-17T16:40:18Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.28%. Comparing base (67b459b) to head (f012a0f).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3885   +/-   ##
=======================================
  Coverage   79.28%   79.28%           
=======================================
  Files         281      281           
  Lines       12754    12755    +1     
  Branches     2844     2844           
=======================================
+ Hits        10112    10113    +1     
  Misses       2642     2642

Flag	Coverage Δ
backend	`79.28% <100.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Also makes existing tests less brittle when re-ran

…lowfuse into 3815-snapshot-actions

also, ensure downloads dir is cleared before test

cstns

partial review, unable to leave more comments for it due to This diff is outdated, please refresh and try again.

frontend/src/pages/application/Snapshots.vue

cstns · 2024-05-21T09:56:16Z

frontend/src/pages/application/Snapshots.vue

+ kind: 'danger',
+ confirmLabel: 'Delete'
+ }, async () => {
+ await SnapshotsApi.deleteSnapshot(snapshot.id)


Should we treat possible failures?

Sorry, not sure what the question is here

Was wondering if we should threat the possibility for the deleteSnapshot endpoint to fail

frontend/src/pages/application/Snapshots.vue

cstns

haven't went over the cypress tests yet, would love to have a chat before starting to make changes

frontend/src/pages/device/Snapshots/index.vue

frontend/src/pages/instance/Snapshots/index.vue

…lowfuse into 3815-snapshot-actions

Steve-Mcl · 2024-05-22T09:04:12Z

@cstns all suggestions we discussed now in place and working and tests passing again. Ready for (re)review.

cstns

Looks good on my end! We can move forward even without the modal validation when deleting snapshots because i couldn't find any other delete dialogs that implement such a catch

cstns · 2024-05-22T09:07:35Z

frontend/src/pages/application/Snapshots.vue

+ kind: 'danger',
+ confirmLabel: 'Delete'
+ }, async () => {
+ await SnapshotsApi.deleteSnapshot(snapshot.id)


Was wondering if we should threat the possibility for the deleteSnapshot endpoint to fail

Better symmetry between the snapshot table views kebab menus

a6db01f

github-actions bot added the deploy:pr label May 17, 2024

Steve-Mcl and others added 2 commits May 20, 2024 12:23

add tests for menus

4994472

Also makes existing tests less brittle when re-ran

Merge branch 'main' into 3815-snapshot-actions

aa16617

Steve-Mcl temporarily deployed to staging May 20, 2024 11:31 — with GitHub Actions Inactive

Steve-Mcl added 2 commits May 20, 2024 14:15

fix e2e tests

baa2268

Merge branch '3815-snapshot-actions' of https://github.com/FlowFuse/f…

b0a1dde

…lowfuse into 3815-snapshot-actions

Steve-Mcl temporarily deployed to staging May 20, 2024 13:19 — with GitHub Actions Inactive

update docs for snapshot menu changes

4ae1fde

Steve-Mcl changed the title ~~Better symmetry between the snapshot table views kebab menus~~ Improve snapshot actions across devices, instances and applications May 20, 2024

Steve-Mcl requested a review from joepavitt May 20, 2024 14:02

Steve-Mcl marked this pull request as ready for review May 20, 2024 14:02

Steve-Mcl temporarily deployed to staging May 20, 2024 14:03 — with GitHub Actions Inactive

This was referenced May 20, 2024

Changelog entry for snapshots... FlowFuse/website#2079

Closed

Changelog: Snapshot actions FlowFuse/website#2080

Merged

missed doc update

9a8a728

Steve-Mcl temporarily deployed to staging May 20, 2024 14:41 — with GitHub Actions Inactive

fix intermittent and first run e2e tests

0a1be83

Steve-Mcl temporarily deployed to staging May 20, 2024 15:21 — with GitHub Actions Inactive

fix intermittent download json tests

8b58921

also, ensure downloads dir is cleared before test

Steve-Mcl temporarily deployed to staging May 20, 2024 16:14 — with GitHub Actions Inactive

handle missing downloads dir in e2e test env

b9f7d2a

Steve-Mcl temporarily deployed to staging May 20, 2024 16:37 — with GitHub Actions Inactive

remove commented code

774c689

Steve-Mcl temporarily deployed to staging May 21, 2024 07:45 — with GitHub Actions Inactive

joepavitt requested review from cstns and removed request for joepavitt May 21, 2024 08:29

Merge branch 'main' into 3815-snapshot-actions

7284fa8

cstns temporarily deployed to staging May 21, 2024 09:17 — with GitHub Actions Inactive

Merge branch 'main' into 3815-snapshot-actions

5f361d8

Steve-Mcl temporarily deployed to staging May 21, 2024 09:36 — with GitHub Actions Inactive

cstns reviewed May 21, 2024

View reviewed changes

Steve-Mcl added 4 commits May 21, 2024 17:26

refactor application of auto snapshot pseudo user to a transformer

30d8d50

refactor multiple duplicates of download code into a composable

15001ab

fix package download for viewer role

9ba7a6a

update snapshots GET api test for including modules and device/project

2474d0f

Steve-Mcl temporarily deployed to staging May 21, 2024 16:46 — with GitHub Actions Inactive

fix snapshot e2e test following move to new snapshots api

ffcfc1f

Steve-Mcl temporarily deployed to staging May 21, 2024 18:18 — with GitHub Actions Inactive

Merge branch 'main' into 3815-snapshot-actions

58939a1

Steve-Mcl temporarily deployed to staging May 21, 2024 18:27 — with GitHub Actions Inactive

Steve-Mcl added 2 commits May 22, 2024 09:54

fix test for package download - use correct data

dcdcbb2

Merge branch '3815-snapshot-actions' of https://github.com/FlowFuse/f…

3e4c6fa

…lowfuse into 3815-snapshot-actions

Steve-Mcl temporarily deployed to staging May 22, 2024 08:57 — with GitHub Actions Inactive

Steve-Mcl requested a review from cstns May 22, 2024 09:03

cstns approved these changes May 22, 2024

View reviewed changes

Merge branch 'main' into 3815-snapshot-actions

f012a0f

Steve-Mcl temporarily deployed to staging May 22, 2024 10:06 — with GitHub Actions Inactive

Steve-Mcl merged commit 78ee033 into main May 22, 2024
13 checks passed

Steve-Mcl deleted the 3815-snapshot-actions branch May 22, 2024 10:14

Steve-Mcl temporarily deployed to staging May 22, 2024 10:14 — with GitHub Actions Inactive

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve snapshot actions across devices, instances and applications #3885

Improve snapshot actions across devices, instances and applications #3885

Steve-Mcl commented May 17, 2024 •

edited

codecov bot commented May 17, 2024 •

edited

cstns left a comment

cstns May 21, 2024

Steve-Mcl May 21, 2024

cstns May 22, 2024

cstns left a comment

Steve-Mcl commented May 22, 2024

cstns left a comment

cstns May 22, 2024

Improve snapshot actions across devices, instances and applications #3885

Improve snapshot actions across devices, instances and applications #3885

Conversation

Steve-Mcl commented May 17, 2024 • edited

Description

Caveats

TODO:

Related Issue(s)

Checklist

Labels

codecov bot commented May 17, 2024 • edited

Codecov Report

cstns left a comment

Choose a reason for hiding this comment

cstns May 21, 2024

Choose a reason for hiding this comment

Steve-Mcl May 21, 2024

Choose a reason for hiding this comment

cstns May 22, 2024

Choose a reason for hiding this comment

cstns left a comment

Choose a reason for hiding this comment

Steve-Mcl commented May 22, 2024

cstns left a comment

Choose a reason for hiding this comment

cstns May 22, 2024

Choose a reason for hiding this comment

Steve-Mcl commented May 17, 2024 •

edited

codecov bot commented May 17, 2024 •

edited