-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add custom hostname support to Instances #3830
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3830 +/- ##
==========================================
- Coverage 79.28% 78.52% -0.77%
==========================================
Files 281 284 +3
Lines 12755 12945 +190
Branches 2844 2886 +42
==========================================
+ Hits 10113 10165 +52
- Misses 2642 2780 +138
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
/api/v1/project/:uid/customHostname/domainstatus
hardillb
commented
Jun 4, 2024
hardillb
commented
Jun 5, 2024
Co-authored-by: Ben Hardill <[email protected]>
Co-authored-by: Ben Hardill <[email protected]>
Docs update for custom hostnames
knolleary
approved these changes
Jun 5, 2024
knolleary
changed the title
324 - Allow users to set custom hostnames for instances
Add custom hostname support to Instances
Jun 5, 2024
Going to hit merge once tests pass |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
UI work for #324
Will also include the ee work
Related Issue(s)
Checklist
flowforge.yml
?FlowFuse/helm
to update ConfigMap TemplateFlowFuse/CloudProject
to update values for Staging/ProductionLabels
backport
labelarea:migration
label