Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom hostname support to Instances #3830

Merged
merged 49 commits into from
Jun 5, 2024
Merged

Add custom hostname support to Instances #3830

merged 49 commits into from
Jun 5, 2024

Conversation

hardillb
Copy link
Contributor

@hardillb hardillb commented May 7, 2024

Description

UI work for #324

Will also include the ee work

Related Issue(s)

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

@hardillb hardillb self-assigned this May 7, 2024
Copy link

codecov bot commented May 7, 2024

Codecov Report

Attention: Patch coverage is 19.26606% with 88 lines in your changes missing coverage. Please review.

Project coverage is 78.52%. Comparing base (b622261) to head (8a3dd0f).
Report is 96 commits behind head on main.

Files Patch % Lines
forge/ee/routes/customHostnames/index.js 12.98% 67 Missing ⚠️
forge/ee/lib/customHostnames/index.js 23.52% 13 Missing ⚠️
forge/db/models/ProjectSettings.js 25.00% 3 Missing ⚠️
forge/db/views/Project.js 50.00% 2 Missing ⚠️
forge/routes/api/project.js 0.00% 2 Missing ⚠️
forge/routes/api/settings.js 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3830      +/-   ##
==========================================
- Coverage   79.28%   78.52%   -0.77%     
==========================================
  Files         281      284       +3     
  Lines       12755    12945     +190     
  Branches     2844     2886      +42     
==========================================
+ Hits        10113    10165      +52     
- Misses       2642     2780     +138     
Flag Coverage Δ
backend 78.52% <19.26%> (-0.77%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

/api/v1/project/:uid/customHostname/domainstatus
@hardillb hardillb requested a review from knolleary June 4, 2024 13:21
@knolleary knolleary changed the title 324 - Allow users to set custom hostnames for instances Add custom hostname support to Instances Jun 5, 2024
@knolleary
Copy link
Member

Going to hit merge once tests pass

@knolleary knolleary merged commit ecc4ec6 into main Jun 5, 2024
12 of 13 checks passed
@knolleary knolleary deleted the custom-hostname branch June 5, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants