Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ToolGood.Words.Pinyin from 3.0.1.4 to 3.1.0 #1835

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 23, 2023

Bumps ToolGood.Words.Pinyin from 3.0.1.4 to 3.1.0.

Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
> **Note** > Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

Bumps [ToolGood.Words.Pinyin](https://github.com/toolgood/ToolGood.Words.Pinyin) from 3.0.1.4 to 3.1.0.
- [Release notes](https://github.com/toolgood/ToolGood.Words.Pinyin/releases)
- [Commits](https://github.com/toolgood/ToolGood.Words.Pinyin/commits)

---
updated-dependencies:
- dependency-name: ToolGood.Words.Pinyin
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added .NET Pull requests that update .net code dependencies Pull requests that update a dependency file labels Jan 23, 2023
@github-actions
Copy link

github-actions bot commented Jan 23, 2023

@check-spelling-bot Report

🔴 Please review

See the 📂 files view or the 📜action log for details.

Unrecognized words (2)

automerge
automerging

To accept ✔️ these unrecognized words as correct and remove the previously acknowledged and now absent words, run the following commands

... in a clone of the [email protected]:Flow-Launcher/Flow.Launcher.git repository
on the dependabot/nuget/ToolGood.Words.Pinyin-3.1.0 branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/main/apply.pl' |
perl - 'https://github.com/Flow-Launcher/Flow.Launcher/actions/runs/3990979238/attempts/1'

To have the bot do this for you, reply quoting the following line:
@check-spelling-bot apply updates.

If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

@taooceros
Copy link
Member

It does introduce a significant memory usage. Although I think it is acceptable, since that will only apply to people who uses pinyin (and it does provide better pinyin).

@jjw24
Copy link
Member

jjw24 commented Jan 28, 2023

  1. How much memory difference are we talking?

  2. What better Pinyin does it provide with the upgrade?

@taooceros
Copy link
Member

around 100M

I don't really know what exactly more pinyin is provided. Probably check the commit history? toolgood/ToolGood.Words.Pinyin@dcf03a4

@jjw24
Copy link
Member

jjw24 commented Feb 6, 2023

I feel like maybe we should delay this upgrade unless there are some issue/missing pinyin, a 100mb increase is quite a lot and can be mistaken as flow itself taking up a lot of memory. What do you think?

@taooceros
Copy link
Member

I feel like maybe we should delay this upgrade unless there are some issue/missing pinyin, a 100mb increase is quite a lot and can be mistaken as flow itself taking up a lot of memory. What do you think?

well sure

@jjw24
Copy link
Member

jjw24 commented Aug 7, 2023

Just converting this to draft until we actually need to bump it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file .NET Pull requests that update .net code no-pr-activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants