Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix Pydantic misbehaving with Freezegun #3871

Closed
wants to merge 1 commit into from

Conversation

khvn26
Copy link
Member

@khvn26 khvn26 commented May 1, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Please describe.

How did you test this code?

Please describe.

Copy link

vercel bot commented May 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 1, 2024 8:26pm
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 1, 2024 8:26pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 1, 2024 8:26pm

Copy link
Contributor

github-actions bot commented May 1, 2024

Uffizzi Ephemeral Environment deployment-51128

☁️ https://app.uffizzi.com/github.com/Flagsmith/flagsmith/pull/3871

📄 View Application Logs etc.

What is Uffizzi? Learn more!

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.87%. Comparing base (41981d4) to head (d441b39).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3871   +/-   ##
=======================================
  Coverage   95.86%   95.87%           
=======================================
  Files        1131     1131           
  Lines       35834    35841    +7     
=======================================
+ Hits        34354    34361    +7     
  Misses       1480     1480           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@zachaysan zachaysan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate the effort, but this does not solve the error.

@zachaysan
Copy link
Contributor

We ended up merging the workaround here:

#3876

Feel free to try to improve it if you want.

@zachaysan zachaysan closed this May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants