chore: restrict external HTTP calls in tests #3866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khvn26
requested review from
a team and
matthewelwell
and removed request for
a team
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Uffizzi Preview |
khvn26
force-pushed
the
chore/restrict-http-in-tests
branch
from
189043f
to
8a3a597
Compare
khvn26
force-pushed
the
chore/restrict-http-in-tests
branch
from
8a3a597
to
4e88215
Compare
khvn26
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3866 +/- ##
==========================================
- Coverage 95.87% 95.87% -0.01%
==========================================
Files 1133 1133
Lines 35873 35883 +10
==========================================
+ Hits 34393 34402 +9
- Misses 1480 1481 +1 ☔ View full report in Codecov by Sentry. |
|
@matthewelwell This is now ready for review. |
matthewelwell
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
pre-committo check lintingdocs/if required so people know about the feature!Changes
This PR adds a global restriction of HTTP requests in unit tests.
When an external HTTP call is detected, the test trying to perform it fails with a notice/instruction to developers.
This PR will also add fixes to the current offending tests.
How did you test this code?
Ran the test suite.