Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Navigation improvements #3864

Merged
merged 54 commits into from May 9, 2024
Merged

style: Navigation improvements #3864

merged 54 commits into from May 9, 2024

Conversation

kyle-ssg
Copy link
Member

@kyle-ssg kyle-ssg commented May 1, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Improves navigation such that

  • Segments, integrations and compare no longer have environment ids in their urls
  • Header nav sits above sidebar and show sub navigation based on if we are viewing the organisation or project
  • The side menu will only show for environment specific pages
  • Switching environments is done via a select vs showing them all as a collapsable list
  • The top nav has a breadcrumb and menu allowing users to navigate to any organisation or project
  • Clicking home will go to an organisation select page
  • Users and permissions and usage is separated from settings at the organisation level
  • Settings / usage links are restricted to organisation admin
  • Reduces font sizes in some places
  • Moves SDK keys to top level navigation
  • Dev experience: Migrates some components to RTK and TypeScript
  • Dev experience: removes a lot of custom css
  • Minor: Remove unused images

How did you test this code?

Please describe.

@kyle-ssg kyle-ssg marked this pull request as draft May 1, 2024 06:50
Copy link

vercel bot commented May 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 9, 2024 8:31am
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 9, 2024 8:31am
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 9, 2024 8:31am

Copy link
Contributor

@zachaysan zachaysan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the stuff I've tested looks good. Really like this refactor.

@matthewelwell
Copy link
Contributor

Seems like there's still some nasty debugging going on here. I managed to get this to appear by just navigating to project settings.

image

@kyle-ssg
Copy link
Member Author

kyle-ssg commented May 9, 2024

Figured this out, was due to tags and is an existing issue in production. This PR will resolve it.

Copy link
Contributor

@matthewelwell matthewelwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed above issue as fixed.

@kyle-ssg kyle-ssg added this pull request to the merge queue May 9, 2024
Merged via the queue into main with commit d92c082 May 9, 2024
21 checks passed
@kyle-ssg kyle-ssg deleted the style/nav-poc branch May 9, 2024 14:02
Copy link

sentry-io bot commented May 11, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ TypeError: Cannot read properties of undefined (reading 'tags') <object>.renderRow(web/components/pages/UserPage) View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
front-end Issue related to the React Front End Dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants