Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add plan based access to stale tag filtering #3852

Merged
merged 3 commits into from May 8, 2024

Conversation

kyle-ssg
Copy link
Member

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

  • Disables stale tags based on plan

image
image

Please describe.

How did you test this code?

  • Viewed stale tag filter from non enterprise org

Copy link

vercel bot commented Apr 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 1, 2024 9:13am
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 1, 2024 9:13am
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 1, 2024 9:13am

Copy link
Contributor

github-actions bot commented Apr 29, 2024

Uffizzi Preview deployment-50955 was deleted.

@kyle-ssg kyle-ssg changed the title Add plan based access to stale tag filtering chore: Add plan based access to stale tag filtering Apr 29, 2024
@matthewelwell
Copy link
Contributor

matthewelwell commented Apr 29, 2024

@kyle-ssg this seems to have broken something. I can't access the following project via the preview URL (but I can through app.flagsmith.com):

Preview: https://flagsmith-frontend-preview-git-chore-add-plan-a4de52-flagsmith.vercel.app/project/16448/environment/9xQWUbkXpn3oy97gpnhfmx/features

Production: https://app.flagsmith.com/project/16448/environment/9xQWUbkXpn3oy97gpnhfmx/features

I've added your user to the organisation as an admin.

@kyle-ssg
Copy link
Member Author

kyle-ssg commented May 1, 2024

@matthewelwell ah yep I see the problem, this is now fixed

@kyle-ssg kyle-ssg added this pull request to the merge queue May 8, 2024
Merged via the queue into main with commit 211bb93 May 8, 2024
21 checks passed
@kyle-ssg kyle-ssg deleted the chore/add-plan-based-tags branch May 8, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
front-end Issue related to the React Front End Dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants