Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: versioned segment override change request #3790

Merged
merged 12 commits into from May 9, 2024
Merged

feat: versioned segment override change request #3790

merged 12 commits into from May 9, 2024

Conversation

kyle-ssg
Copy link
Member

@kyle-ssg kyle-ssg commented Apr 17, 2024 •
edited

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

  • Environments with versioning + Change Requests enabled will now have the ability to create a change request for segment overrides
    image

  • Change requests now diff all of the feature states in comparison to live, irrespective of if versioning is enabled.

Much like versioning this will tell you changed, created and unchanged values

image

image

image

  • The create feature modal toast will now differentiate when a change request was created vs editing a feature. Creating a change request will close the create feature modal

  • Removed a confusing unused field "hide_from_client" from feature states

  • Note: versioned change requests cannot be edited due to the limited use case and complexity of updating a versions feature states in a change request.

How did you test this code?

  • Created, edited and removed segment overrides in a change request on an environment with versioning

@vercel Vercel
Copy link

vercel bot commented Apr 17, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2024 1:07pm
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2024 1:07pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2024 1:07pm

@github-actions github-actions bot added the front-end Issue related to the React Front End Dashboard label Apr 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 17, 2024 •
edited

Uffizzi Preview deployment-50354 was deleted.

@kyle-ssg
Merge branch 'main' into feat/versioned-segment-override-change-request
862be93 
# Conflicts:
#	frontend/common/types/requests.ts
#	frontend/web/components/modals/CreateFlag.js
matthewelwell
matthewelwell approved these changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@matthewelwell matthewelwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an outstanding bug in the API which is resolved here but this PR seems sound.

I've also added one minor suggestion which we should probably add before merging.

frontend/common/services/useFeatureState.ts Show resolved Hide resolved
kyle-ssg and others added 3 commits May 1, 2024 10:10
@kyle-ssg @matthewelwell
Update frontend/common/services/useFeatureState.ts
174fe47 
Co-authored-by: Matthew Elwell <[email protected]>
@kyle-ssg
Merge branch 'main' into feat/versioned-segment-override-change-request
23cf501 
# Conflicts:
#	frontend/common/types/responses.ts
@kyle-ssg
Merge remote-tracking branch 'origin/feat/versioned-segment-override-…
6289bf0 
…change-request' into feat/versioned-segment-override-change-request
@matthewelwell
Copy link
Contributor

@kyle-ssg I've just noticed that the change request view doesn't actually show which segment a feature is being overridden by?

image

@matthewelwell
Copy link
Contributor

Also, is there anything we can do to improve the view when you remove a segment override? I'm just seeing this

image

@kyle-ssg
Copy link
Member Author

kyle-ssg commented May 1, 2024

@matthewelwell both issues should be resolved now

@matthewelwell
Copy link
Contributor

matthewelwell commented May 2, 2024 •
edited

@kyle-ssg when you create a CR with more than one segment override, the priority values don't seem right.

image

@matthewelwell
Copy link
Contributor

@kyle-ssg I can't create any change requests now with segment overrides following the latest change:

image

@matthewelwell matthewelwell added this pull request to the merge queue May 9, 2024
Merged via the queue into main with commit cf320b7 May 9, 2024
21 checks passed
@matthewelwell matthewelwell deleted the feat/versioned-segment-override-change-request branch May 9, 2024 07:56
@dabeeeenster dabeeeenster mentioned this pull request May 8, 2024
Merged
@kyle-ssg
Copy link
Member Author

Related #1204

@kyle-ssg kyle-ssg linked an issue May 15, 2024 that may be closed by this pull request
Change requests for changes to segment overrides #1204
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewelwell matthewelwell matthewelwell approved these changes

@novakzaballa novakzaballa Awaiting requested review from novakzaballa

Assignees
No one assigned
Labels
front-end Issue related to the React Front End Dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change requests for changes to segment overrides
2 participants
@kyle-ssg @matthewelwell