Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add metadata fields to core entities (FE) #3212

Merged
merged 136 commits into from May 15, 2024

Conversation

novakzaballa
Copy link
Contributor

@novakzaballa novakzaballa commented Dec 21, 2023

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

PR Re-created (ORIGINAL: #2861)
FE changes:

  • Add and create metadata to Environments, segments, and Flags
  • The feature was wrapped inside the 'enable_metadata' flag

BE changes:

How did you test this code?

  • Run feat/add-metadata-fields-to-core-entities-api
  • Go to Project settings
  • Click the Metadata tab.
  • Create Metadata.
  • Click on the metadata created, And select the entities you want to have metadata.

Copy link
Contributor

@matthewelwell matthewelwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving since the one comment I had on the frontend changes has been resolved. The rest are API related, and the API code was moved to a separate PR.

@kyle-ssg kyle-ssg linked an issue May 15, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API docs front-end Issue related to the React Front End Dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add additional meta data to Identities
5 participants