fix(task-processor): the extraEnv where added in the wrong place #220
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
/charts/flagsmith/Chart.yaml
in the sectionversion
or I'm merging to arelease branch
Changes
Fix bug introduced in thhis pr #187
The environment variables added for the task processor should go inside the container that runs the task processor rather in the deployment template spec.
The task processor was already including the api environment so it was not necessary to add merge both
extraEnv
Also the
extraEnv
keys and values were added as yaml (key: value
), instead of the expected object with thename
andvalue
keys.How did you test this code?
I test it manually. With a values
The expected result in the api deployment, inside the
flagsmith-task-processor
containerand in the task processor deployment, inside the
flagsmith-task-processor
container