Persistent, Inpersistent(temporary) holograms #96
Conversation
| /** | ||
| * Returns a read-only view of the currently loaded persistent holograms. | ||
| * | ||
| * @return A read-only collection of holograms. | ||
| */ | ||
| @Override | ||
| public @NotNull | ||
| @UnmodifiableView Collection<Hologram> getHolograms() { | ||
| return this.holograms.values().stream().filter(hologram -> hologram.getData().isPersistent()).toList(); | ||
| } | ||
|
|
There was a problem hiding this comment.
I think I would personally name this getPersistentHolograms and then revert getAllHolograms to getHolograms.
|
Just thought I'd prompt this thought that I just had - would |
probably, let me test and resolve it if thats the case |
|
This PR will resolve #50 |
fixed with 28f18f2 |
|
Awesome, I think the only thing left would be to look at those methods names mentioned above |
No description provided.