Major Code Rewrite #94
Conversation
…iled error for api users
# Conflicts: # src/main/java/de/oliver/fancyholograms/commands/hologram/CopyCMD.java
| @@ -101,18 +92,17 @@ public void removeHologram(@NotNull final Hologram hologram) { | |||
| Optional<Hologram> optionalHologram = ofNullable(this.holograms.remove(name.toLowerCase(Locale.ROOT))); | |||
|
|
|||
| optionalHologram.ifPresent(hologram -> | |||
| FancyHolograms.get().getScheduler().runTaskAsynchronously(() -> { | |||
| final var online = List.copyOf(Bukkit.getOnlinePlayers()); | |||
| FancyHolograms.get().getHologramThread().submit(() -> { | |||
There was a problem hiding this comment.
Execute all the hologram updates in the less executor tasks possible otherwise it will cause notable slowdowns by the massive amount of queued tasks
api/src/main/java/de/oliver/fancyholograms/api/hologram/Hologram.java
Outdated
Show resolved
Hide resolved
|
If you want to make this actually decent the whole system should be rewritten with a central "entity tracker", instead of submitting new tasks so often |
I do agree that this would be beneficial, I'd be down to do this. The main goal of this PR initially was just the data rewrite but I thought I might as well try fix the thread issue while I was doing this rewrite. But it definitely can't harm to take this as an opportunity |
|
I have not yet made changes to creating, removing, hiding or showing holograms to players. Regarding creating and removing I need to get my head around the current implementation before making any changes. I'll likely make |
|
I think this pr is relatively read to go now, the only thing I haven't done is changed creating and removing holograms but that could be done in a separate pr (Unless anyone has any immediate improvements that could be made) |
|
Can vouch that this performs exceptionally better than FancyHolograms upstream! |
… rewrite # Conflicts: # api/src/main/java/de/oliver/fancyholograms/api/data/DisplayHologramData.java # api/src/main/java/de/oliver/fancyholograms/api/data/HologramData.java # api/src/main/java/de/oliver/fancyholograms/api/data/TextHologramData.java # api/src/main/java/de/oliver/fancyholograms/api/events/HologramUpdateEvent.java # api/src/main/java/de/oliver/fancyholograms/api/hologram/Hologram.java # src/main/java/de/oliver/fancyholograms/HologramManagerImpl.java # src/main/java/de/oliver/fancyholograms/commands/FancyHologramsTestCMD.java # src/main/java/de/oliver/fancyholograms/commands/hologram/CreateCMD.java # src/main/java/de/oliver/fancyholograms/commands/hologram/VisibilityCMD.java # src/main/java/de/oliver/fancyholograms/storage/FlatFileHologramStorage.java
|
This should now have no conflicts, the recent features |
Changes
I am open to suggestions, and can understand if reverting the api file tree is requested
I have tested this on a local server and have not found any issues, this will of course need testing by others