[DBX-34] Update API to get current database settings #3934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DB-15 New API to get current database settings
When a user has no access to the box (for example, in ES Cloud), they can't see how the database is configured. For any sort of "control plane" it would be necessary to tell the Ops user what settings the database have. It will also make it easier for Ops people on the customer side to report their configuration to support when they open a ticket. It's not directly related to the "change settings via API" project, but it seems connected. Clarify: should the settings be persisted to the config file? Allow both temporary and permanent changes? |
pvanbuijtene
reviewed
Sep 6, 2023
src/EventStore.Core/Services/Transport/Http/Controllers/InfoController.cs
Outdated
Show resolved
Hide resolved
dhingrak
force-pushed
the
kunaldhingra/db-15-new-api-to-get-current-database-settings
branch
3 times, most recently
from
f60dca9
to
3110e48
Compare
hayley-jean
changed the title
hayley-jean
changed the title
dhingrak
force-pushed
the
kunaldhingra/db-15-new-api-to-get-current-database-settings
branch
4 times, most recently
from
9819de3
to
a7d269a
Compare
timothycoleman
changed the title
hayley-jean
requested changes
May 23, 2024
dhingrak
force-pushed
the
kunaldhingra/db-15-new-api-to-get-current-database-settings
branch
from
a7d269a
to
88f5db8
Compare
hayley-jean
approved these changes
May 29, 2024
hayley-jean
deleted the
kunaldhingra/db-15-new-api-to-get-current-database-settings
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added: Add more information to the current database settings API response
Fixes: https://linear.app/eventstore/issue/DB-15/new-api-to-get-current-database-settings
The goal of this PR is to provide more information regarding the EventStoreDB database setting so the user who does not have access to the system can see how the database is configured. Attached the current API response and the new API response.
oldAPIresponse.txt
newAPIresponse.txt