Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Builder] - Enhancement - Updates Builder StaticImports.py #358

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kdschlosser
Copy link
Member

Changes the name of Build StaticImport.py to Build IDE Integration (StaticImports.py)
Adds additional information into the docstring of StaticImports.py
Removes RegisterPlugin from StaticImports.py
Creates symbolic links for CorePluginModule and UserPluginModule.
Adds eg\CorePluginModule and eg\UserPluginModule to gitignore

Changes the name of build StaticImport.py to Build IDE Integration
Adds additional information into thee docstring of StaticImports.py
Removes RegisterPlugin from StaticImports.py
Creates symbolic links for CorePluginModule and UserPluginModule.
Adds eg\CorePluginModule and eg\UserPluginModule to gitignore
@codeclimate
Copy link

codeclimate bot commented Jan 18, 2019

Code Climate has analyzed commit 6340cc8 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

View more on Code Climate.

Copy link
Contributor

@topic2k topic2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So if i understand correct, this will only be needed once (when i setup my development environment) and not for building an EventGhost exe? Then i would propose to remove it from Builder and make it runable standalone. Show a Dialog with the information what it does and give the user the choice of continue or abort.

Do the symbolic links be visible in explorer? I ask because i think i never used symbolic links before. Can they be deleted or changed? (Mabye add that info also to the docstring.)

_build/builder/BuildIDEIntegration.py Show resolved Hide resolved
if not CreateSymbolicLinkW(lpSymlinkFileName, lpTargetFileName, dwFlags):
print (
'Build IDE Integration: '
'Unable to create symbolic links user MUST '
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing punctuation.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what punctuation???

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'Unable to create symbolic links**,** user MUST '
'be in the Administrators group**.**'

_build/builder/BuildIDEIntegration.py Show resolved Hide resolved
@kdschlosser
Copy link
Member Author

Yeah I can do that. The StaticImports has always been in the builder. I simply changed the name so people will know what it actually does.

A symlink is visible in explorer. Think of a symlink like a Pointer when programming. It simply points to a location. But in reality it contains nothing it's self. You can delete a symlink like any other file or folder. Except when you delete a symlink folder it does not delete the data that is conatined in it. It simply deletes the pointer. I did the symlinks so you can do

from eg.CorePluginModule import Webserver

And it will code complete and also show you a list of all of the plugins.

Right now there is a large chunk of code in eg/init.py that I can move to StaticImports. I will clean it out and do a try except to import StaticImports. If it is there then it will work it's magic.

What I did is I have a copy of EG that is only for purposes of setting the environment. I do not modify it. It never gets run. It is only there for use with PyCharm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants