Move physics enter/exit back to reactors #10193
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As part of the physics API refactor, the physics ECS component create/destroy functionality were moved from component reactors to enter/exit queries. This was due to insuficiencies in the gaurantees of scene loading.
This concern has since been addressed, and with the recent upgrades to hookstate that allow for a changing source to be hooked, we can simplify the component reactors. This includes changes to useAncestorWithComponent and useChildWithComponent that now react to changes in passed arguments.
Subtasks Checklist
Breaking Changes
References
closes #insert number here
QA Steps