Add percentage labels to volume and brightness indicators #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ferdi265
force-pushed
the
volume-brightness-percentage
branch
from
b172bef
to
25e69ae
Compare
ErikReider
requested changes
Feb 12, 2024
Ferdi265
force-pushed
the
volume-brightness-percentage
branch
from
25e69ae
to
9e12cd5
Compare
Yes, that is my thought as well. I'm completely fine with leaving this PR hanging until config support is added, I might even help with implementing config support if I find time. |
Ferdi265
force-pushed
the
volume-brightness-percentage
branch
3 times, most recently
from
c6f84c5
to
c9b6d0d
Compare
|
Rebased on top of #79 and added a configuration option to enable percentage display. |
Ferdi265
force-pushed
the
volume-brightness-percentage
branch
from
c9b6d0d
to
04a6652
Compare
|
I'll wait until #79 is merged :) |
Ferdi265
force-pushed
the
volume-brightness-percentage
branch
from
04a6652
to
2463549
Compare
Ferdi265
force-pushed
the
volume-brightness-percentage
branch
from
2463549
to
07f7107
Compare
Ferdi265
force-pushed
the
volume-brightness-percentage
branch
from
07f7107
to
c6c9604
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a textual percentage next to the progress bar in the volume and brightness indicators. This is useful for users who still want to know the exact volume percentage set in practice.
Optimally this should be configurable, but this PR currently just unconditionally adds these percentage indicators. I will potentially add configurability if I find time.