Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed dayViewHeaderFormat #2907

Merged
merged 1 commit into from
May 16, 2024
Merged

Conversation

chirmac
Copy link
Contributor

@chirmac chirmac commented May 14, 2024

PRs relating to the v4 will be closed and locked.

  • Please check if the PR fulfills these requirements
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...). If this is a fix, please tag a bug.
    Simple fix on the dayViewHeaderFormat: for some reason, the format parameters were in Portuguese instead of the expected English.

  • What is the current behavior? (You can also link to an open issue here)
    Current behavior throws an error, since the current configuration is not accepted by the API

  • What is the new behavior (if this is a feature change)?
    No longer throws an error

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    No breaking changes

  • Other information:
    The day names in Portuguese are too big for the calendar but it works

Copy link

@Kiefna Kiefna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Eonasdan Eonasdan merged commit 25fb008 into Eonasdan:master May 16, 2024
@Eonasdan
Copy link
Owner

thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants