Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typing, some refactor, run and fix all doctests #196

Draft
wants to merge 34 commits into
base: master
Choose a base branch
from

Conversation

artemisart
Copy link
Contributor

@artemisart artemisart commented Feb 3, 2024

  • type type type many things
  • doctests were not run ! fixed all doctests, there were many errors
  • make outer join follow the input ordering (avoids sets)
  • factorise & reuse some methods -> we can remove the implementation of distinct, select, where, order_by, flatten, zip_with_index, init
  • remove PRE_COMPUTE by doing the lists in the functions where needed
  • simplify some counters, group by operations
  • fix some exception types (ValueError that should be TypeError, ...)

TODO potential improvement: improve typing on _wrap returns like __getitem__

@artemisart artemisart force-pushed the typing-and-maintenance branch 2 times, most recently from ee7fb87 to c732978 Compare February 3, 2024 12:17
@artemisart artemisart changed the title Add typing Add typing, some refactor Feb 3, 2024
@artemisart artemisart force-pushed the typing-and-maintenance branch 3 times, most recently from e39b8b4 to 2f840cd Compare February 4, 2024 16:51
@artemisart artemisart changed the title Add typing, some refactor Add typing, some refactor, run and fix all doctests Feb 5, 2024
@maestro-1
Copy link
Contributor

Don't you think the changes in this might be too much to push all at once?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants